; Fix backport of help-fns--analyze-function bug fix

* lisp/help-fns.el (help-fns--analyze-function):
Add back the NOERROR argument to function-alias-p, needed because
Emacs 29 doesn't prevent the creation of circular function aliases.
This fixes a failure in help-fns-tests.

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index eb50f3b26caa54b53c79fce5f2cb178f8f5c7dc8..044bcf8b51fc2c33e218898a899eac8f68e602e0 100644 (file)
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -995,7 +995,7 @@ Returns a list of the form (REAL-FUNCTION DEF ALIASED REAL-DEF)."
                                               (symbol-name function)))))))
         (real-def (cond
                     ((and aliased (not (subrp def)))
-                     (or (car (function-alias-p real-function))
+                     (or (car (function-alias-p real-function t))
                          real-function))
                    ((subrp def) (intern (subr-name def)))
                     (t def))))