* xmenu.c (popup_get_selection): Only pop down dialogs

on C-g and Escape.

diff --git a/src/ChangeLog b/src/ChangeLog
index eafd381817fce3cc482d95de726f2aadc41105db..f016801fd96ca8493862cd24d6bc5c12fa2943a0 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,8 @@
+2004-12-27  Jan Dj\e,Ad\e(Brv  <jan.h.d@swipnet.se>
+
+       * xmenu.c (popup_get_selection): Only pop down dialogs
+       on C-g and Escape.
+
 2004-12-27  YAMAMOTO Mitsuharu  <mituharu@math.s.chiba-u.ac.jp>
 
        * dispextern.h: Change HAVE_CARBON to MAC_OS.

diff --git a/src/xmenu.c b/src/xmenu.c
index 55c28d831e81bf396edf9cd36a13b260ac428935..ba4177fab67650a42ec6beed37c4ac41d716f5fc 100644 (file)
--- a/src/xmenu.c
+++ b/src/xmenu.c
@@ -1232,25 +1232,16 @@ popup_get_selection (initial_event, dpyinfo, id, do_timers, down_on_keypress)
           event.xbutton.state = 0;
 #endif
         }
-      /* If the user presses a key that doesn't go to the menu,
-         deactivate the menu.
-         The user is likely to do that if we get wedged.
-         All toolkits now pop down menus on ESC.
-         For dialogs however, the focus may not be on the dialog, so
-         in that case, we pop down. */
+      /* Pop down on C-g and Escape.  */
       else if (event.type == KeyPress
                && down_on_keypress
                && dpyinfo->display == event.xbutton.display)
         {
           KeySym keysym = XLookupKeysym (&event.xkey, 0);
 
-          /* Pop down on C-g.  */
-          if (keysym == XK_g && (event.xkey.state & ControlMask) != 0)
+          if ((keysym == XK_g && (event.xkey.state & ControlMask) != 0)
+              || keysym == XK_Escape) /* Any escape, ignore modifiers.  */
             popup_activated_flag = 0;
-
-          if (!IsModifierKey (keysym)
-              && x_any_window_to_frame (dpyinfo, event.xany.window) != NULL)
-           popup_activated_flag = 0;
         }
 
       x_dispatch_event (&event, event.xany.display);