Re-fix build warnings about subr-x defsubsts

* lisp/term/haiku-win.el (require):
* lisp/progmodes/elisp-mode.el (require):
* lisp/isearch.el (require): Require subr-x at compile time, since
these use defsubsts/macros from there.

* lisp/emacs-lisp/subr-x.el (string-empty-p): Move from here...
* lisp/simple.el (string-empty-p): ... to here.  This is to help
with a build problem where files.el is using the defsubst, but
requiring subr-x.el at compile time leads to load errors.

diff --git a/lisp/emacs-lisp/subr-x.el b/lisp/emacs-lisp/subr-x.el
index b0de5d155ac2aca651f04b62b607ce6593bdeccf..390e505f00970b61fdb89b38f829ca25c4c647da 100644 (file)
--- a/lisp/emacs-lisp/subr-x.el
+++ b/lisp/emacs-lisp/subr-x.el
@@ -97,10 +97,6 @@ threading."
     (maphash (lambda (_ v) (push v values)) hash-table)
     values))
 
-(defsubst string-empty-p (string)
-  "Check whether STRING is empty."
-  (string= string ""))
-
 (defsubst string-join (strings &optional separator)
   "Join all STRINGS using SEPARATOR.
 Optional argument SEPARATOR must be a string, a vector, or a list of

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 7650ebcfcea20116d335b05c014a38a93127879f..0624858993d5e2bb225a6cde63e71ba70b4e30c5 100644 (file)
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -54,6 +54,7 @@
 ;;; Code:
 
 (eval-when-compile (require 'cl-lib))
+(eval-when-compile (require 'subr-x))
 \f
 ;; Some additional options and constants.
 

diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index 332488e6d412c860a4d959c92d055092704021dd..fc2576793402813d23d4edf6e867a793f5371b5d 100644 (file)
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -31,6 +31,7 @@
 (require 'cl-generic)
 (require 'lisp-mode)
 (eval-when-compile (require 'cl-lib))
+(eval-when-compile (require 'subr-x))
 
 (define-abbrev-table 'emacs-lisp-mode-abbrev-table ()
   "Abbrev table for Emacs Lisp mode.

diff --git a/lisp/simple.el b/lisp/simple.el
index 8f82ff3a8e855a5a55e24ca70da93723eb718c09..2b11a6362fd731dc4ab15bb83a354965b94a2896 100644 (file)
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -10620,6 +10620,10 @@ If the buffer doesn't exist, create it first."
           (save-buffer)))
       t)))
 
+(defsubst string-empty-p (string)
+  "Check whether STRING is empty."
+  (string= string ""))
+
 \f
 
 (provide 'simple)

diff --git a/lisp/term/haiku-win.el b/lisp/term/haiku-win.el
index 5443904a733bf2de4bee1c1eb8e73999d94ddea8..024459e64754769517d2b378f530c9161b68c595 100644 (file)
--- a/lisp/term/haiku-win.el
+++ b/lisp/term/haiku-win.el
@@ -24,6 +24,7 @@
 ;;; Code:
 
 (eval-when-compile (require 'cl-lib))
+(eval-when-compile (require 'subr-x))
 (unless (featurep 'haiku)
   (error "%s: Loading haiku-win without having Haiku"
          invocation-name))