(report-emacs-bug): In message-mode, sort manually before storing

original report text.  (Bug#5178)
Remove superfluous save-excursion.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index fa6cd869ebce4118e2bb5550b20b33e1f7f5f872..27c14b00aae0ec978c2be01afa6c8ec3e8d49a71 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
+2009-12-13  Glenn Morris  <rgm@gnu.org>
+
+       * mail/emacsbug.el (report-emacs-bug): In message-mode, sort manually
+       before storing original report text.  (Bug#5178)
+       Remove superfluous save-excursion.
+
 2009-12-12  Michael Albinus  <michael.albinus@gmx.de>
 
        * net/dbus.el (dbus-property-handler): Filter lambda forms out

diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index 2ecca76b5f93be123f74e64257b2502b2ff684c3..9fafab565b54e97d00498e64e25b6660f82a4d46 100644 (file)
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -106,11 +106,14 @@ Prompts for bug subject.  Leaves you in a mail buffer."
          (with-current-buffer (get-buffer-create "*Messages*")
            (point-max-marker)))
     (compose-mail reporting-address topic)
-    ;; The rest of this does not execute
-    ;; if the user was asked to confirm and said no.
+    ;; The rest of this does not execute if the user was asked to
+    ;; confirm and said no.
+    ;; Message-mode sorts the headers before sending.  We sort now so
+    ;; that report-emacs-bug-orig-text remains valid.  (Bug#5178)
+    (if (eq major-mode 'message-mode)
+        (message-sort-headers))
     (rfc822-goto-eoh)
     (forward-line 1)
-
     (let ((signature (buffer-substring (point) (point-max))))
       (delete-region (point) (point-max))
       (insert signature)
@@ -262,12 +265,11 @@ usually do not have translators to read other languages for them.\n\n")
     ;; Make it less likely people will send empty messages.
     (if report-emacs-bug-send-hook
         (add-hook report-emacs-bug-send-hook 'report-emacs-bug-hook nil t))
-    (save-excursion
-      (goto-char (point-max))
-      (skip-chars-backward " \t\n")
-      (make-local-variable 'report-emacs-bug-orig-text)
-      (setq report-emacs-bug-orig-text
-            (buffer-substring-no-properties (point-min) (point))))
+    (goto-char (point-max))
+    (skip-chars-backward " \t\n")
+    (make-local-variable 'report-emacs-bug-orig-text)
+    (setq report-emacs-bug-orig-text
+          (buffer-substring-no-properties (point-min) (point)))
     (goto-char user-point)))
 
 (defun report-emacs-bug-info ()