* editfns.c: Tune. Don't use wider integers than needed. Don't use alloca.

Use a bigger 'string' buffer.  Rewrite to avoid 'n > 0' test.

diff --git a/src/ChangeLog b/src/ChangeLog
index d53817369c0086bd72d1b619eb0f1ba04e41b144..011f5beefe0813cba723456729409de1ead600b2 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,6 +1,8 @@
 2011-06-16  Paul Eggert  <eggert@cs.ucla.edu>
 
        * editfns.c (Finsert_char): Don't dump core with very negative counts.
+       Tune.  Don't use wider integers than needed.  Don't use alloca.
+       Use a bigger 'string' buffer.  Rewrite to avoid 'n > 0' test.
 
        * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
 

diff --git a/src/editfns.c b/src/editfns.c
index ab17eda86a95e6a7c844a21156dc91baf0fdaa1f..2d736bbc7e2233108c7838b3c75c1eef8744393a 100644 (file)
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -2328,12 +2328,11 @@ The optional third arg INHERIT, if non-nil, says to inherit text properties
 from adjoining text, if those properties are sticky.  */)
   (Lisp_Object character, Lisp_Object count, Lisp_Object inherit)
 {
-  register char *string;
-  register EMACS_INT stringlen;
-  register int i;
+  int i, stringlen;
   register EMACS_INT n;
   int c, len;
   unsigned char str[MAX_MULTIBYTE_LENGTH];
+  char string[4000];
 
   CHECK_CHARACTER (character);
   CHECK_NUMBER (count);
@@ -2348,11 +2347,10 @@ from adjoining text, if those properties are sticky.  */)
   if (BUF_BYTES_MAX / len < XINT (count))
     buffer_overflow ();
   n = XINT (count) * len;
-  stringlen = min (n, 256 * len);
-  string = (char *) alloca (stringlen);
+  stringlen = min (n, sizeof string - sizeof string % len);
   for (i = 0; i < stringlen; i++)
     string[i] = str[i % len];
-  while (n >= stringlen)
+  while (n > stringlen)
     {
       QUIT;
       if (!NILP (inherit))
@@ -2361,13 +2359,10 @@ from adjoining text, if those properties are sticky.  */)
        insert (string, stringlen);
       n -= stringlen;
     }
-  if (n > 0)
-    {
-      if (!NILP (inherit))
-       insert_and_inherit (string, n);
-      else
-       insert (string, n);
-    }
+  if (!NILP (inherit))
+    insert_and_inherit (string, n);
+  else
+    insert (string, n);
   return Qnil;
 }