Fix starting eshell with missing/invalid modules defined

* lisp/eshell/esh-mode.el (eshell-mode): Warn instead of failing to
start when 'eshell-modules-list' has invalid entries.  (Bug#54976)

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index c21484dc45f38198537a850948412388241cae9c..db36909fb86f9c745fc425727bd4e2a0c2811b0c 100644 (file)
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -361,7 +361,11 @@ and the hook `eshell-exit-hook'."
       (unless module-shortname
        (error "Invalid Eshell module name: %s" module-fullname))
       (unless (featurep (intern module-shortname))
-       (load module-shortname))))
+        (condition-case nil
+            (load module-shortname)
+          (error (lwarn 'eshell :error
+                        "Unable to load module `%s' (defined in `eshell-modules-list')"
+                        module-fullname))))))
 
   (unless (file-exists-p eshell-directory-name)
     (eshell-make-private-directory eshell-directory-name t))