Partially revert last Gnus merge.

The add-face function has been added gnus-compat.el, but is not in
Emacs; this leaves Gnus in an unusable state.

* lisp/gnus/gnus-salt.el (gnus-tree-highlight-node):
* lisp/gnus/gnus-sum.el (gnus-summary-highlight-line):
* lisp/gnus/gnus-group.el (gnus-group-highlight-line): Revert use of add-face.

* lisp/gnus/gnus-util.el (gnus-put-text-property-excluding-characters-with-faces): Restore.

diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog
index 48d57da8f8dd1b31f8b7a654f191cfc6c0b2ecce..d9f80103435c4ac66ad6d51c1b72308276eab869 100644 (file)
--- a/lisp/gnus/ChangeLog
+++ b/lisp/gnus/ChangeLog
@@ -1,3 +1,12 @@
+2012-09-07  Chong Yidong  <cyd@gnu.org>
+
+       * gnus-util.el
+       (gnus-put-text-property-excluding-characters-with-faces): Restore.
+
+       * gnus-salt.el (gnus-tree-highlight-node):
+       * gnus-sum.el (gnus-summary-highlight-line):
+       * gnus-group.el (gnus-group-highlight-line): Revert use of add-face.
+
 2012-09-06  Lars Ingebrigtsen  <larsi@gnus.org>
 
        * gnus-util.el: Fix compilation error on XEmacs 21.4.

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index 24406fcc04e0c9987f81b6b6e3bbde70452affd1..8c7d0165976bdfb0ae8b82adacad56ff30c4a031 100644 (file)
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -1669,7 +1669,9 @@ and ends at END."
                       gnus-group-highlight))))
     (unless (eq face (get-text-property beg 'face))
       (let ((inhibit-read-only t))
-        (add-face beg end (if (boundp face) (symbol-value face) face)))
+        (gnus-put-text-property-excluding-characters-with-faces
+         beg end 'face
+         (if (boundp face) (symbol-value face) face)))
       (gnus-extent-start-open beg))))
 
 (defun gnus-group-get-icon (group)

diff --git a/lisp/gnus/gnus-salt.el b/lisp/gnus/gnus-salt.el
index 87a120279bc7f878af1ed3d7ae102df7e83d2bf2..760a7a0942ed39695469cbeb487c9f8a2c673fd1 100644 (file)
--- a/lisp/gnus/gnus-salt.el
+++ b/lisp/gnus/gnus-salt.el
@@ -660,7 +660,9 @@ Two predefined functions are available:
                    (not (eval (caar list))))
          (setq list (cdr list)))))
     (unless (eq (setq face (cdar list)) (get-text-property beg 'face))
-      (add-face beg end (if (boundp face) (symbol-value face) face)))))
+      (gnus-put-text-property-excluding-characters-with-faces
+       beg end 'face
+       (if (boundp face) (symbol-value face) face)))))
 
 (defun gnus-tree-indent (level)
   (insert (make-string (1- (* (1+ gnus-tree-node-length) level)) ? )))

diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el
index bc0addd15591ea49f6fa094c1d84e504c22a4df5..b44b953bec64bb12f07792491c7749fbaaa1b9d9 100644 (file)
--- a/lisp/gnus/gnus-sum.el
+++ b/lisp/gnus/gnus-sum.el
@@ -12522,8 +12522,9 @@ If REVERSE, save parts that do not match TYPE."
                         (not (memq article gnus-newsgroup-cached)))))
     (let ((face (funcall (gnus-summary-highlight-line-0))))
       (unless (eq face (get-text-property beg 'face))
-       (add-face beg (point-at-eol)
-                 (setq face (if (boundp face) (symbol-value face) face)))
+       (gnus-put-text-property-excluding-characters-with-faces
+        beg (point-at-eol) 'face
+        (setq face (if (boundp face) (symbol-value face) face)))
        (when gnus-summary-highlight-line-function
          (funcall gnus-summary-highlight-line-function article face))))))
 

diff --git a/lisp/gnus/gnus-util.el b/lisp/gnus/gnus-util.el
index 0c048e63bdf9a6a52655d4a9700158fbbdaf7a4b..4c5eabab723845d8a52e22961dc79d07278dcbf4 100644 (file)
--- a/lisp/gnus/gnus-util.el
+++ b/lisp/gnus/gnus-util.el
@@ -866,6 +866,19 @@ If there's no subdirectory, delete DIRECTORY as well."
          (setq beg (point)))
        (gnus-overlay-put (gnus-make-overlay beg (point)) prop val)))))
 
+(defun gnus-put-text-property-excluding-characters-with-faces (beg end
+                                                                  prop val)
+  "The same as `put-text-property', but don't put props on characters with the `gnus-face' property."
+  (let ((b beg))
+    (while (/= b end)
+      (when (get-text-property b 'gnus-face)
+       (setq b (next-single-property-change b 'gnus-face nil end)))
+      (when (/= b end)
+       (inline
+         (gnus-put-text-property
+          b (setq b (next-single-property-change b 'gnus-face nil end))
+          prop val))))))
+
 (defmacro gnus-faces-at (position)
   "Return a list of faces at POSITION."
   (if (featurep 'xemacs)