src/emacs.c now gets version number from configure.in

diff --git a/ChangeLog b/ChangeLog
index bded0a22921c3c38abb8112c4159a2311607f2c9..20d9e4dbc5736531afa3548fec163f294f45425b 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-01-31  Paul Eggert  <eggert@cs.ucla.edu>
+
+       src/emacs.c now gets version number from configure.in
+       * configure.in (version): Set this from $PACKAGE_VERSION,
+       which is set from AC_INIT, rather than scouting through src/emacs.c.
+       * configure: Regenerate.
+       * make-dist (version): Get it from configure.in, not src/emacs.c.
+
 2011-01-30  Paul Eggert  <eggert@cs.ucla.edu>
 
        strftime: import from gnulib

diff --git a/admin/ChangeLog b/admin/ChangeLog
index 04fcf732bd9b52953b93d0d981cada1d0527db20..6f2ac5d67d5efb768b698dd80a0159617d628c0e 100644 (file)
--- a/admin/ChangeLog
+++ b/admin/ChangeLog
@@ -1,3 +1,10 @@
+2011-01-31  Paul Eggert  <eggert@cs.ucla.edu>
+
+       src/emacs.c now gets version number from configure.in
+       * admin.el (set-version): Don't update src/emacs.c.
+       * quick-install-emacs (VERSION): Get it from configure.in, not from
+       src/emacs.c.
+
 2011-01-30  Paul Eggert  <eggert@cs.ucla.edu>
 
        strftime: import from gnulib

diff --git a/admin/admin.el b/admin/admin.el
index 5365cc77d2436128cde5c84366be303f775b4fc0..739c769b3528c4f0e7cecdede77562a91421f2dd 100644 (file)
--- a/admin/admin.el
+++ b/admin/admin.el
@@ -59,9 +59,6 @@ Root must be the root of an Emacs source tree."
   (interactive "DEmacs root directory: \nsVersion number: ")
   (unless (file-exists-p (expand-file-name "src/emacs.c" root))
     (error "%s doesn't seem to be the root of an Emacs source tree" root))
-  (set-version-in-file root "src/emacs.c" version
-                      (rx (and "emacs_version" (0+ (not (in ?\")))
-                               ?\" (submatch (1+ (not (in ?\")))) ?\")))
   (set-version-in-file root "README" version
                       (rx (and "version" (1+ space)
                                (submatch (1+ (in "0-9."))))))

diff --git a/admin/quick-install-emacs b/admin/quick-install-emacs
index 0711f8e4b432658daf234ce7966105930b76dc01..841a895248e2f53c0e47c7a0a5f79f4656be4b11 100755 (executable)
--- a/admin/quick-install-emacs
+++ b/admin/quick-install-emacs
@@ -170,8 +170,10 @@ test x"$SRC" = x && { SRC="`get_config_var srcdir`" || exit 4 ; }
 test x"$prefix" = x && { prefix="`get_config_var prefix`" || exit 4 ; }
 test x"$ARCH" = x && { ARCH="`get_config_var host`" || exit 4 ; }
 
-VERSION=`grep 'char emacs_version' $SRC/src/emacs.c \
-         | sed -e 's/^[^"]*"\([^"]*\)".*$/\1/'`
+VERSION=`
+  sed -n 's/^AC_INIT(emacs,[    ]*\([^  )]*\).*/\1/p' <$SRC/configure.in
+` || exit 4
+test -n "$VERSION" || { echo >&2 "$me: no version in configure.in"; exit 4; }
 
 DST_SHARE="$prefix/share/emacs/$VERSION"
 DST_BIN="$prefix/bin"

diff --git a/configure b/configure
index aea8d2d079f354224341c047249d6e5df80571f4..bf79cecf5b4441156c1fb45a348249f3f49a0390 100755 (executable)
--- a/configure
+++ b/configure
@@ -16986,16 +16986,7 @@ if test "x$GCC" = xyes \
    as_fn_error $? "GCC 4.5.0 has problems compiling Emacs; see etc/PROBLEMS'." "$LINENO" 5
 fi
 
-#### Find out which version of Emacs this is.
-version=`grep 'const char emacs_version' ${srcdir}/src/emacs.c \
-        | sed -e 's/^[^"]*"\([^"]*\)".*$/\1/'`
-if test x"${version}" = x; then
-  as_fn_error $? "can't find current emacs version in \`${srcdir}/src/emacs.c'." "$LINENO" 5
-fi
-if test x"${version}" != x"$PACKAGE_VERSION"; then
-  { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: version mismatch between \`${srcdir}/configure.in' and \`${srcdir}/src/emacs.c'." >&5
-$as_echo "$as_me: WARNING: version mismatch between \`${srcdir}/configure.in' and \`${srcdir}/src/emacs.c'." >&2;}
-fi
+version=$PACKAGE_VERSION
 
 ### Specify what sort of things we'll be editing into Makefile and config.h.
 ### Use configuration here uncanonicalized to avoid exceeding size limits.

diff --git a/configure.in b/configure.in
index 627b76af59d5778f92cc3a0641ebf64602fae8ea..315840e01462aeb26b45a684d5365d5302226130 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -3070,15 +3070,7 @@ if test "x$GCC" = xyes \
    AC_MSG_ERROR([GCC 4.5.0 has problems compiling Emacs; see etc/PROBLEMS'.])
 fi
 
-#### Find out which version of Emacs this is.
-[version=`grep 'const char emacs_version' ${srcdir}/src/emacs.c \
-        | sed -e 's/^[^"]*"\([^"]*\)".*$/\1/'`]
-if test x"${version}" = x; then
-  AC_MSG_ERROR([can't find current emacs version in `${srcdir}/src/emacs.c'.])
-fi
-if test x"${version}" != x"$PACKAGE_VERSION"; then
-  AC_MSG_WARN([version mismatch between `${srcdir}/configure.in' and `${srcdir}/src/emacs.c'.])
-fi
+version=$PACKAGE_VERSION
 
 ### Specify what sort of things we'll be editing into Makefile and config.h.
 ### Use configuration here uncanonicalized to avoid exceeding size limits.

diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog
index 6428819daa31a623f4b27ad9e83a28197b39ad2a..3f7a17e2db6ff623fae6aa1db9071d2529da01b7 100644 (file)
--- a/lib-src/ChangeLog
+++ b/lib-src/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-31  Paul Eggert  <eggert@cs.ucla.edu>
+
+       src/emacs.c now gets version number from configure.in
+       * ebrowse.c: Adjust comment to say that.
+
 2011-01-30  Jim Meyering  <meyering@redhat.com>
 
        make-docfile: don't corrupt heap for an invalid .elc file

diff --git a/lib-src/ebrowse.c b/lib-src/ebrowse.c
index 87d6938284b4550be86c719d2e0fa04ffb5c9279..59a1dde76347a3b625d431b6c2ffd7dc932cc30b 100644 (file)
--- a/lib-src/ebrowse.c
+++ b/lib-src/ebrowse.c
@@ -3565,7 +3565,7 @@ usage (int error)
 
 
 /* Display version and copyright info.  The VERSION macro is set
-   from the Makefile and contains the Emacs version.  */
+   from config.h and contains the Emacs version.  */
 
 #ifndef VERSION
 # define VERSION "21"
@@ -3812,7 +3812,7 @@ main (int argc, char **argv)
              yyerror ("error getting size of file `%s'", out_filename);
              exit (EXIT_FAILURE);
            }
-         
+
          else if (rc == 0)
            {
              yyerror ("file `%s' is empty", out_filename);

diff --git a/make-dist b/make-dist
index da09c7096f85b234ec4a655f98c75e71615a8f4f..37e0fb3e641cbd5eb23d2d2da594c139fc86d299 100755 (executable)
--- a/make-dist
+++ b/make-dist
@@ -146,7 +146,9 @@ then
 fi
 
 ### Find out which version of Emacs this is.
-version=`sed -n '/char emacs_version/ s/^[^"]*"\([^"]*\)".*$/\1/p' src/emacs.c`
+version=`
+  sed -n 's/^AC_INIT(emacs,[    ]*\([^  )]*\).*/\1/p' <configure.in
+` || version=
 if [ ! "${version}" ]; then
   echo "${progname}: can't find current Emacs version in \`./src/emacs.c'" >&2
   exit 1

diff --git a/src/ChangeLog b/src/ChangeLog
index 393223c080285bfc7511916d9c4ac1ee83d44c39..5a3c34dcc2d4839c55d38c1bd8d05b2189084b25 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2011-01-31  Paul Eggert  <eggert@cs.ucla.edu>
+
+       src/emacs.c now gets version number from configure.in
+       * emacs.c (emacs_version): Set to VERSION so that it
+       is determined automatically from ../configure.in.
+
 2011-01-30  Paul Eggert  <eggert@cs.ucla.edu>
 
        strftime: import from gnulib

diff --git a/src/emacs.c b/src/emacs.c
index e696c8202983830d23643fd78fad13edd7435edb..53786b0adae7e92c2c551386fca8e35b6e3e5a2c 100644 (file)
--- a/src/emacs.c
+++ b/src/emacs.c
@@ -88,9 +88,7 @@ along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.  */
 #endif
 #endif
 
-/* If you change the following line, remember to update
-   msdos/mainmake.v2 which gleans the Emacs version from it!  */
-static const char emacs_version[] = "24.0.50";
+static const char emacs_version[] = VERSION;
 static const char emacs_copyright[] = "Copyright (C) 2011 Free Software Foundation, Inc.";
 
 /* Make these values available in GDB, which doesn't see macros.  */