]> git.eshelyaron.com Git - emacs.git/commitdiff
Forward completion text properties in 'completion-table-with-quoting'
authorJim Porter <jporterbugs@gmail.com>
Sat, 11 Nov 2023 21:26:44 +0000 (13:26 -0800)
committerJim Porter <jporterbugs@gmail.com>
Sun, 19 Nov 2023 23:11:40 +0000 (15:11 -0800)
This fixes an issue with 'pcomplete-here-using-help', which passes
annotation strings along as text properties.  Previously, those got
clobbered when the completions got requoted (bug#67112).

* lisp/minibuffer.el (completion--twq-all): Apply text properties from
the first character of the unquoted completion to the quoted
completion.

lisp/minibuffer.el

index 7af7a35967467e938358b782657cd81ff3f6f338..5c12d9fc9147c8b49f2d94dbe1d85016e3defa27 100644 (file)
@@ -677,6 +677,13 @@ for use at QPOS."
                                              'completions-common-part)
                                qprefix))))
                         (qcompletion (concat qprefix qnew)))
+                   ;; Some completion tables (including this one) pass
+                   ;; along necessary information as text properties
+                   ;; on the first character of the completion.  Make
+                   ;; sure the quoted completion has these properties
+                   ;; too.
+                   (add-text-properties 0 1 (text-properties-at 0 completion)
+                                        qcompletion)
                    ;; Attach unquoted completion string, which is needed
                    ;; to score the completion in `completion--flex-score'.
                    (put-text-property 0 1 'completion--unquoted