-2011-03-24 Paul Eggert <eggert@cs.ucla.edu>
+2011-03-27 Paul Eggert <eggert@cs.ucla.edu>
+
++ * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
++ concerns.
++
++ * term.c (produce_glyphless_glyph): Remove unnecessary test.
++
++ * cm.c (calccost): Turn while-do into do-while, for clarity.
+
+ * keyboard.c (syms_of_keyboard): Use the same style as later
+ in this function when indexing through an array. This also
+ works around GCC bug 48267.
+
+ * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
+
+ * xselect.c (x_check_property_data): Return correct size (Bug#8335).
+
-2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
+ * chartab.c (sub_char_table_ref_and_range): Redo for slight
+ efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
- * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
- concerns.
+ * keyboard.c, keyboard.h (num_input_events): Now size_t.
+ This avoids undefined behavior on integer overflow, and is a bit
+ more convenient anyway since it is compared to a size_t variable.
- * chartab.c (sub_char_table_ref_and_range): Redo to avoid overflow
- concerns.
+ Variadic C functions now count arguments with size_t, not int.
+ This avoids an unnecessary limitation on 64-bit machines, which
+ caused (substring ...) to crash on large vectors (Bug#8344).
+ * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
+ (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
+ All variadic functions changed accordingly.
+ (struct gcpro.nvars): Now size_t, not int. All uses changed.
+ * data.c (arith_driver, float_arith_driver): Likewise.
+ * editfns.c (general_insert_function): Likewise.
+ * eval.c (struct backtrace.nargs, interactive_p)
+ (internal_condition_case_n, run_hook_with_args, apply_lambda)
+ (funcall_lambda, mark_backtrace): Likewise.
+ * fns.c (concat): Likewise.
+ * frame.c (x_set_frame_parameters): Likewise.
+ * fns.c (get_key_arg): Now accepts and returns size_t, and returns
+ 0 if not found, not -1. All callers changed.
- * term.c (produce_glyphless_glyph): Remove unnecessary test.
+2011-03-26 Paul Eggert <eggert@cs.ucla.edu>
- * cm.c (calccost): Turn while-do into do-while, for clarity.
+ * alloc.c (garbage_collect): Don't assume stack size fits in int.
+ (stack_copy_size): Now size_t, not int.
+ (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
+
+2011-03-27 Glenn Morris <rgm@gnu.org>
+
+ * syssignal.h: Replace RETSIGTYPE with void.
+ * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
+ * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
+ Replace SIGTYPE with void everywhere.
+ * s/usg5-4-common.h (SIGTYPE): Remove definition.
+ * s/template.h (SIGTYPE): Remove commented out definition.
+
+2011-03-26 Eli Zaretskii <eliz@gnu.org>
+
+ * xdisp.c (redisplay_window): Don't check buffer's clip_changed
+ flag as a prerequisite for invoking try_scrolling. (Bug#6671)
+
+2011-03-26 Juanma Barranquero <lekktu@gmail.com>
+
+ * w32.c (read_unc_volume): Use parameter `henum', instead of
+ global variable `wget_enum_handle'.
+
+ * keymap.c (describe_vector): Remove parameters `indices' and
+ `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
+ (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
+
+ * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
+
+ * keyboard.c (timer_check): Remove parameter `do_it_now',
+ unused since 1996-04-12T06:01:29Z!rms@gnu.org.
+ (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
+ unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
+
+ * keyboard.c (read_char):
+ * w32menu.c (w32_menu_display_help):
+ * xmenu.c (show_help_event, menu_help_callback):
+ Adjust calls to `show_help_echo'.
+
+ * gtkutil.c (xg_maybe_add_timer):
+ * keyboard.c (readable_events):
+ * process.c (wait_reading_process_output):
+ * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
+
+ * insdel.c (adjust_markers_gap_motion):
+ Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
+ (gap_left, gap_right): Don't call it.
+
+2011-03-25 Chong Yidong <cyd@stupidchicken.com>
+
+ * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
+ incurred during fontification.
+
+2011-03-25 Juanma Barranquero <lekktu@gmail.com>
+
+ * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
+ (DEFVAR_PER_BUFFER): Don't pass it.
+
+ * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
+ (scrolling_window): Don't pass it.
+
+2011-03-25 Juanma Barranquero <lekktu@gmail.com>
+
+ * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
+
+ * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
+ and `suffix'.
+ (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
+ of variables specific to SELinux and computation of `encoded_absname'.
+
+ * image.c (XPutPixel): Remove unused variable `height'.
+
+ * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
+
+ * unexw32.c (get_section_info): Remove unused variable `section'.
+
+ * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
+ (system_process_attributes): Remove unused variable `sess'.
+ (sys_read): Remove unused variable `err'.
+
+ * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
+ (w32_wnd_proc): Remove unused variable `isdead'.
+ (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
+ (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
+ (x_create_tip_frame): Remove unused variable `tem'.
+
+ * w32inevt.c (w32_console_read_socket):
+ Remove unused variable `no_events'.
+
+ * w32term.c (x_draw_composite_glyph_string_foreground):
+ Remove unused variable `width'.
+
+2011-03-24 Juanma Barranquero <lekktu@gmail.com>
+
+ * w32term.c (x_set_glyph_string_clipping):
+ Don't pass uninitialized region to CombineRgn.
+
+2011-03-23 Juanma Barranquero <lekktu@gmail.com>
+
+ * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
+ (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
+ (Fx_close_connection): Remove unused variable `i'.
+
+ * w32font.c (w32font_draw): Return number of glyphs.
+ (w32font_open_internal): Remove unused variable `i'.
+ (w32font_driver): Add missing initializer.
+
+ * w32menu.c (utf8to16): Remove unused variable `utf16'.
+ (fill_in_menu): Remove unused variable `items_added'.
+
+ * w32term.c (last_mouse_press_frame): Remove static global variable.
+ (w32_clip_to_row): Remove unused variable `f'.
+ (x_delete_terminal): Remove unused variable `i'.
+
+ * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
+ (NOTHING): Remove unused static global variable.
+ (uniscribe_check_otf): Remove unused variable `table'.
+ (uniscribe_font_driver): Add missing initializers.
+
+2011-03-23 Julien Danjou <julien@danjou.info>
+
+ * term.c (Fsuspend_tty, Fresume_tty):
+ * minibuf.c (read_minibuf, run_exit_minibuf_hook):
+ * window.c (temp_output_buffer_show):
+ * insdel.c (signal_before_change):
+ * frame.c (Fhandle_switch_frame):
+ * fileio.c (Fdo_auto_save):
+ * emacs.c (Fkill_emacs):
+ * editfns.c (save_excursion_restore):
+ * cmds.c (internal_self_insert):
+ * callint.c (Fcall_interactively):
+ * buffer.c (Fkill_all_local_variables):
+ * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
+ Use Frun_hooks.
+ (command_loop_1): Use Frun_hooks. Call safe_run_hooks
+ unconditionnaly since it does the check itself.
+
+2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
Fix more problems found by GCC 4.5.2's static checks.
projects / emacs.git / commitdiff