Fix Eshell bug

* eshell/em-term.el (eshell-visual-command-p): Fix bug that
  causedoutput redirection to be ignored with visual commands.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 31746dd8de2702785d40bfd78b4dcf242f7d36fe..b7173c5cacf4a9f7f7a99e0e4980b12bac345462 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2013-06-09  Aidan Gauland  <aidalgol@amuri.net>
+
+       * eshell/em-term.el (eshell-visual-command-p): Fix bug that caused
+       output redirection to be ignored with visual commands.
+
 2013-06-09  Aidan Gauland  <aidalgol@amuri.net>
 
        * eshell/em-term.el (eshell-visual-command-p): New function.

diff --git a/lisp/eshell/em-term.el b/lisp/eshell/em-term.el
index 1ed584df8825d2f74b367a60ec0d5f3a124fcbbd..1d4b2a59d4b64e2444b4f07532424f9d4284f101 100644 (file)
--- a/lisp/eshell/em-term.el
+++ b/lisp/eshell/em-term.el
@@ -141,12 +141,13 @@ character to the invoked process."
 If either COMMAND or a subcommand in ARGS (e.g. git log) is a
 visual command, returns non-nil."
   (let ((command (file-name-nondirectory command)))
-    (or (member command eshell-visual-commands)
-        (member (car args)
-                (cdr (assoc command eshell-visual-subcommands)))
-        (cl-intersection args
-                         (cdr (assoc command eshell-visual-options))
-                         :test 'string=))))
+    (and (eshell-interactive-output-p)
+         (or (member command eshell-visual-commands)
+             (member (car args)
+                     (cdr (assoc command eshell-visual-subcommands)))
+             (cl-intersection args
+                              (cdr (assoc command eshell-visual-options))
+                              :test 'string=)))))
 
 (defun eshell-exec-visual (&rest args)
   "Run the specified PROGRAM in a terminal emulation buffer.