]> git.eshelyaron.com Git - emacs.git/commit
Make gravatar.el more configurable
authorBasil L. Contovounesios <contovob@tcd.ie>
Mon, 22 Jul 2019 20:57:39 +0000 (21:57 +0100)
committerBasil L. Contovounesios <contovob@tcd.ie>
Fri, 2 Aug 2019 13:33:30 +0000 (16:33 +0300)
commiteddf4664d786e16b34f6bd0af238a567feb5012c
treec4da65620a382bbe612e7631d51a1044ce38c144
parentb4b1eda7fbf4c4f3fa6377bd18d1d1a22e6e4b42
Make gravatar.el more configurable

For discussion, see the following thread:
https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00528.html

* etc/NEWS: Announce changes in gravatar.el user options.

* lisp/image/gravatar.el (gravatar-cache-ttl): Change :type to
number of seconds without changing the default value and while still
accepting other timestamp formats.
(gravatar-rating): Restrict :type to ratings recognized by Gravatar.
(gravatar-size): Allow nil as a value, in which case Gravatar's
default size is used.
(gravatar-default-image, gravatar-force-default): New user options
controlling the Gravatar query parameters 'default' and
'forcedefault', respectively.
(gravatar-base-url): Use HTTPS.
(gravatar--query-string): New helper function to facilitate testing.
(gravatar-build-url): Use it.

* test/lisp/image/gravatar-tests.el (gravatar-size)
(gravatar-default-image, gravatar-force-default)
(gravatar-build-url): New tests.
etc/NEWS
lisp/image/gravatar.el
test/lisp/image/gravatar-tests.el