]> git.eshelyaron.com Git - emacs.git/commit
Port new fingerprinting scheme to clang + LTO
authorPaul Eggert <eggert@cs.ucla.edu>
Sat, 4 May 2019 20:15:29 +0000 (13:15 -0700)
committerPaul Eggert <eggert@cs.ucla.edu>
Sat, 4 May 2019 20:16:15 +0000 (13:16 -0700)
commitebecafbd19e2ba55ba90bfc9f7de88f4742479ad
tree891c2640137fadcf223664cbf18cefb2479ccaf6
parent4fd9048e940d38364caf4abe9b209f9288c78544
Port new fingerprinting scheme to clang + LTO

* lib-src/make-fingerprint.c (main): Don't consider multiple
instances of the fingerprint to be an error, as this can
happen with clang and -flto.  Instead, replace all instances
of the fingerprint.  There is a tiny chance that this will
silently corrupt the Emacs executable.

This patch suggests that we should go back to fingerprinting
the inputs to the linker instead of its output, as the new
fingerprinting scheme is unnecessarily complicated and this
complexity reduces reliability. The old scheme (i.e., before
commit 2019-05-14T23:31:24Z!eggert@cs.ucla.edu) was simpler
and more portable and good enough, and it's looking like it
would be less trouble in practice than the new scheme.
lib-src/make-fingerprint.c