]> git.eshelyaron.com Git - emacs.git/commit
Do call debugger on failed cl-assert
authorNoam Postavsky <npostavs@gmail.com>
Tue, 8 Nov 2016 01:03:48 +0000 (20:03 -0500)
committerNoam Postavsky <npostavs@gmail.com>
Wed, 9 Nov 2016 00:54:03 +0000 (19:54 -0500)
commiteb364fddec1431f459166cebb36f09f6b371dd71
treec2815dcdf89f34108af0e9a7f075204f6ff2e8bd
parent3ef4ee84fa3f658c2df802569dc89023d98e9947
Do call debugger on failed cl-assert

"Don't call debug on failed cl-assert..." removed the call to `debug' in
cl--assertion-failed because `debug' calls `kill-emacs' in batch mode,
thus messing up ert test runs.  However, calling the debugger is useful
because it allows catching failed assertions even inside
`condition-case' calls.  The problem with ert can be avoided by calling
`debugger' instead of `debug' directly, since ert installs its own
debugger while running tests.

* lisp/emacs-lisp/cl-preloaded.el (cl--assertion-failed): Call
`debugger' if `debug-on-error' is non-nil.
lisp/emacs-lisp/cl-preloaded.el