]> git.eshelyaron.com Git - emacs.git/commit
Allow querying auth-source with port as string in ERC
authorTrevor Arjeski <tmarjeski@gmail.com>
Sun, 24 Nov 2024 20:35:41 +0000 (23:35 +0300)
committerEshel Yaron <me@eshelyaron.com>
Wed, 4 Dec 2024 17:02:19 +0000 (18:02 +0100)
commite3ec6b24f37f4b1721bc47110fe3f787a7af7f0f
treef7e8841675360b3db2b53d92304e795d9007811e
parent2111af98c9ae2cba9cdfbd0abbd27f078cb633ff
Allow querying auth-source with port as string in ERC

* lisp/erc/erc.el (erc--auth-source-determine-params-defaults): Allow
arbitrary strings for `ers-session-port'.  Previously, if a port/service
was any string other than "irc", the auth-source query would fail for a
seemingly unknown reason.  Restricting the value to "irc" is unnecessary
since "irc" is already added to the list of ports, and
`make-network-process' already consults /etc/services for well-known
service names, like "ircs-u", etc.  This change allows a user to (setopt
erc-port "1234"), intentionally or accidentally, while still being able
to use .authinfo for password management.  (Bug#74516)

Copyright-paperwork-exempt: yes
(cherry picked from commit d899519221b23a895672a100f63410ffb8b8b1e4)
lisp/erc/erc.el