]> git.eshelyaron.com Git - emacs.git/commit
Fix ert-tests.el for the new `handler-bind` code
authorStefan Monnier <monnier@iro.umontreal.ca>
Thu, 28 Dec 2023 05:46:36 +0000 (00:46 -0500)
committerEshel Yaron <me@eshelyaron.com>
Fri, 5 Jan 2024 08:19:01 +0000 (09:19 +0100)
commitcbfcdebc158922fe2478a12e5843d8d6d100fb45
treeb8ee10669d7581757b00b19659a63798aac7520e
parent26b2a707fa4f976d1106c14a025f010b66ac0548
Fix ert-tests.el for the new `handler-bind` code

Now that `ert.el` uses `handler-bind` instead of `debugger`, some
details of the behavior have changed.  More specifically,
three tests are now broken, but these basically tested the failure
of ERT's machinery to record errors when ERT was run within
a `condition-case`.
AFAICT, these tests do not check for a behavior that we want,
so rather than "fix" them, I deleted them (bug#67862).

* test/lisp/emacs-lisp/ert-tests.el (ert-test-error-debug)
(ert-test-fail-debug-with-condition-case): Delete.
(ert-test-should-failure-debugging): Don't use `ert-debug-on-error`.
(ert-test-with-demoted-errors): It now passes.  Bug#11218 is fixed!

(cherry picked from commit 25ea99c211ecf91735b44172da19fc53b304c5f4)
test/lisp/emacs-lisp/ert-tests.el