]> git.eshelyaron.com Git - emacs.git/commit
Fix ert-font-lock macro signatures
authorBasil L. Contovounesios <basil@contovou.net>
Thu, 20 Feb 2025 09:29:54 +0000 (10:29 +0100)
committerEshel Yaron <me@eshelyaron.com>
Tue, 4 Mar 2025 20:49:50 +0000 (21:49 +0100)
commitc197faeb52e9f96b485a6a7b6510a5321a3c8691
treecd517e29e984f8d9d700c51284cfe9ae6e6a44b1
parent6ca35612af7c6f3557a3bae0fdc4123042e7e762
Fix ert-font-lock macro signatures

* doc/misc/ert.texi (Syntax Highlighting Tests):
* test/lisp/emacs-lisp/ert-font-lock-tests.el
(test-line-comment-p--emacs-lisp, test-line-comment-p--shell-script)
(test-line-comment-p--javascript, test-line-comment-p--python)
(test-line-comment-p--c, test-macro-test--correct-highlighting)
(test-macro-test--docstring, test-macro-test--failing)
(test-macro-test--file, test-macro-test--file-no-asserts)
(test-macro-test--file-failing): Reindent macro calls.
(with-temp-buffer-str-mode): Evaluate macro arguments left-to-right.
(ert-font-lock--wrap-begin-end): Use rx for more robust composition.
(test-line-comment-p--php): Require that php-mode is callable, not
already loaded.

* lisp/emacs-lisp/ert-font-lock.el (ert-font-lock-deftest)
(ert-font-lock-deftest-file): NAME is not followed by an empty list
like in ert-deftest, so the optional DOCSTRING is actually the
second argument.  Adapt calling convention in docstring, and debug,
doc-string, and indent properties accordingly (bug#76372).  Fix
docstring grammar, document MAJOR-MODE, and avoid referring to a
file name as a path.

(cherry picked from commit 02c830ba22b0564f6725cd403beba4accb836061)
doc/misc/ert.texi
lisp/emacs-lisp/ert-font-lock.el
test/lisp/emacs-lisp/ert-font-lock-tests.el