]> git.eshelyaron.com Git - emacs.git/commit
Don't mess up grouping in completion-all-sorted-completions
authorJoão Távora <joaotavora@gmail.com>
Sun, 22 Aug 2021 14:56:36 +0000 (15:56 +0100)
committerJoão Távora <joaotavora@gmail.com>
Sun, 22 Aug 2021 15:11:40 +0000 (16:11 +0100)
commitba852512f23fdab674086e35d4207e3970dd0912
tree1b7e64bdaf5a2aa530b4e5012c1bd8d6173212d7
parent06c3a321e3cb7a7602fadf1817721a8f1b759604
Don't mess up grouping in completion-all-sorted-completions

The default sorting order will mess up the naturally grouped order of
the candidates in the table that specified the group-function.

As seen in xref.el when

   (setq xref-show-definitions-function
         'xref-show-definitions-completing-read)
   (setq completions-group t)
   M-x fido-mode

Also partially seen with C-x 8 RET (M-x insert-char) with

   (setq read-char-by-name-sort 'code)

bug#48545

* lisp/minibuffer.el (completion-all-sorted-completions): Don't
use default sort if there's a group-function in the table.
lisp/minibuffer.el