]> git.eshelyaron.com Git - emacs.git/commit
Fix command-line parsing regression in erc-cmd-DCC
authorF. Jason Park <jp@neverwas.me>
Sat, 8 Jul 2023 04:27:03 +0000 (21:27 -0700)
committerF. Jason Park <jp@neverwas.me>
Fri, 14 Jul 2023 01:45:31 +0000 (18:45 -0700)
commitb95bb644ec2b9bb9b0aa3ba2a88c828c3c33705a
treecfb4f0215dfe9067f7cb1781af9b3a8e4c0781a5
parent4e8d579f3da93f3f4cb5ae52c179623e75957ee4
Fix command-line parsing regression in erc-cmd-DCC

* lisp/erc/erc-compat.el (erc-compat--28-split-string-shell-command,
erc-compat--split-string-shell-command): Remove unused function and
macro.
* lisp/erc/erc-dcc.el (erc-cmd-DCC): Use own arg-parsing function.
* lisp/erc/erc.el (erc--shell-parse-regexp,
erc--split-string-shell-cmd): New regexp constant and arg-parsing
function based on those in shell.el.
* test/lisp/erc/erc-dcc-tests.el
(erc-dcc-tests--erc-dcc-do-GET-command): Accept new `nuh' argument
representing message source/sender.
(erc-dcc-do-GET-command): Add tests for regression involving pipe
character.
* test/lisp/erc/erc-tests.el (erc--split-string-shell-cmd): New test.
(Bug#62444)

Thanks to Fernando de Morais for reporting this bug.
lisp/erc/erc-compat.el
lisp/erc/erc-dcc.el
lisp/erc/erc.el
test/lisp/erc/erc-dcc-tests.el
test/lisp/erc/erc-tests.el