]> git.eshelyaron.com Git - emacs.git/commit
Warn about implicit logging in erc-truncate-mode
authorF. Jason Park <jp@neverwas.me>
Fri, 18 Aug 2023 02:18:50 +0000 (19:18 -0700)
committerF. Jason Park <jp@neverwas.me>
Fri, 25 Aug 2023 21:47:07 +0000 (14:47 -0700)
commitb93757029c9d8a7e401f7eeb0bc32ca508c212ee
treed191c60c07d6c3e34311d4f4f44c36a60fa61c2f
parent75b3fb3cb42385612d446ee1907b87e64d988c2f
Warn about implicit logging in erc-truncate-mode

* etc/ERC-NEWS: Add entry explaining that `erc-truncate-mode' no
longer quasi-activates `erc-log-mode' under certain conditions.
* lisp/erc/erc-log.el
(erc-log--call-when-logging-enabled-sans-module): Add helper for use
by the `truncate' module during initialization.
* lisp/erc/erc-truncate.el (erc-truncate-mode, erc-truncate-enable,
erc-truncate-disable): Warn on `erc-connect-pre-hook' when conditions
exist that would have seen logging transparently activated in older
ERC versions.
(erc-truncate--warn-about-logging): New function to warn about
implicit logging on pre-connect.
(erc-truncate-buffer-to-size): Clarify some comments and revise doc
string.
* test/lisp/erc/erc-scenarios-log.el (erc-scenarios-log--truncate):
Disable `erc-truncate-mode' even though `erc-modules' is shadowed so
that `erc-insert-done-hook' and friends are not contaminated.
`(Bug#60936)
etc/ERC-NEWS
lisp/erc/erc-log.el
lisp/erc/erc-truncate.el
test/lisp/erc/erc-scenarios-log.el