]> git.eshelyaron.com Git - emacs.git/commit
* lisp/progmodes/sql.el: Try and avoid `eval`; use define-derived-mode
authorStefan Monnier <monnier@iro.umontreal.ca>
Sat, 14 Mar 2020 19:39:31 +0000 (15:39 -0400)
committerStefan Monnier <monnier@iro.umontreal.ca>
Sat, 14 Mar 2020 19:39:31 +0000 (15:39 -0400)
commitb39b5647258297a411fae0adf58877bda85ad00d
tree2cb93a23db613466a7b65a6273fea1e0f95e486a
parente2a15c8ac4efe823c51c9a5750642532155199a8
* lisp/progmodes/sql.el: Try and avoid `eval`; use define-derived-mode

Remove redundant `:group` args.

(sql-interactive-mode-map): `set-keymap-parent` is always fboundp.
(sql-get-product-feature): Prefer `symbol-value` over `eval`.
(sql--adjust-interactive-setup): New function, extracted from
`sql-interactive-mode`.
(sql-interactive-mode): Use it and `define-derived-mode`.
(sql-connect, sql-connection-menu-filter): Prefer `cl-progv` over `eval`.
lisp/progmodes/sql.el