]> git.eshelyaron.com Git - emacs.git/commit
Eglot: beware activation in fundamental-mode
authorJoão Távora <joaotavora@gmail.com>
Thu, 14 Dec 2023 16:32:54 +0000 (16:32 +0000)
committerJoão Távora <joaotavora@gmail.com>
Thu, 14 Dec 2023 18:08:38 +0000 (18:08 +0000)
commitaf1fe69f05d803a6958f9d8a045d1013e2ce785c
treea83b576e2420474a670449d1eac11c85f164cd36
parentd9814efe0759ce916a1c470c5908d2ca3c80b29b
Eglot: beware activation in fundamental-mode

In the specific situation of visiting a buffer via M-. with
eglot-extend-to-xref set to t, it was found that buffer was first
visited in fundamental mode, running after-change-major-mode-hook, and
then again in the proper major mode for the file.  The call to
eglot-current-server of the first visit returned non-nil which cause
two didOpen notifications to be issued for the same file.

Furthermore, in the first call, eglot--languageId to returned nil,
prompting an error from servers such as rust-analyzer.

See also: https://github.com/joaotavora/eglot/discussions/1330

* lisp/progmodes/eglot.el (eglot-current-server): Watch out for
fundamental-mode.
lisp/progmodes/eglot.el