]> git.eshelyaron.com Git - emacs.git/commit
Fix use-package :custom-face to set face-defface-spec (bug#77928)
authorMichael Shields <shields@msrl.com>
Sat, 19 Apr 2025 19:58:26 +0000 (12:58 -0700)
committerEshel Yaron <me@eshelyaron.com>
Sun, 27 Apr 2025 13:29:57 +0000 (15:29 +0200)
commitaccbacaaa15e2bb2265311a347c03e2011f0b62a
tree5c96b9017ff404edd71e51902a97cab0442905c1
parent54defa4267dfb10676da36a6c27cf7c7b1c10f32
Fix use-package :custom-face to set face-defface-spec (bug#77928)

By default, `face-set-spec' sets the override face spec, so face
attributes are combined with defaults rather than replacing them.
This was a behavior change that was an apparently unintended
consequence of commit 6b344a9.

Also set the `face-modified' property, which causes Customize to
flag the face as changed outside Customize.

* doc/misc/use-package.texi (Faces): Document the behavior.
* lisp/use-package/use-package-core.el (use-package-handler/:custom-face):
(use-package): Improve docstring to reflect implementation.
* test/lisp/use-package/use-package-tests.el
(use-package-test/:custom-face-1): (use-package-test/:custom-face-2):
(use-package-test/:custom-face-3): (use-package-test/:custom-face-4):
Add tests.

(cherry picked from commit ebcde0f90f67852d485a36941b0661cfd1b892eb)
doc/misc/use-package.texi
lisp/use-package/use-package-core.el
test/lisp/use-package/use-package-tests.el