]> git.eshelyaron.com Git - emacs.git/commit
Be more cautious in completing Eshell variable assignments
authorJim Porter <jporterbugs@gmail.com>
Sat, 25 Feb 2023 05:49:54 +0000 (21:49 -0800)
committerJim Porter <jporterbugs@gmail.com>
Sun, 26 Feb 2023 04:38:55 +0000 (20:38 -0800)
commit9565e34762af6e0db51e9ae01683eb5d4c97ff3d
tree9f9a1a3a3d0e0d3ddc86adc8bf4d8831283e35b4
parent2baf08683fcf4b6b1ad65a6dc239b889d78a74b2
Be more cautious in completing Eshell variable assignments

Previously, Eshell treated cases like the second argument in "tar
--directory=dir" as a variable assignment, but that prevented
'pcomplete/tar' from implementing its own completion for that
argument (bug#61778).

* lisp/eshell/esh-var.el (eshell-complete-variable-assignment): Only
handle completion when all initial arguments are variable assignments.

* test/lisp/eshell/em-cmpl-tests.el
(em-cmpl-test/variable-assign-completion/non-assignment): New test.
lisp/eshell/esh-var.el
test/lisp/eshell/em-cmpl-tests.el