]> git.eshelyaron.com Git - emacs.git/commit
Fix bugs, inefficiencies and bad style in regexps
authorMattias Engdegård <mattiase@acm.org>
Thu, 16 Apr 2020 09:04:24 +0000 (11:04 +0200)
committerMattias Engdegård <mattiase@acm.org>
Thu, 16 Apr 2020 10:14:38 +0000 (12:14 +0200)
commit905c0a13f7929298cb36151f46dbef03f7bdcbe4
treeb2adb12f5e6810bf3784628efae69828bba3c464
parent01436fddfb2587271391e72b7eaa6c5c541b46d8
Fix bugs, inefficiencies and bad style in regexps

Found by relint.  See discussion at
https://lists.gnu.org/archive/html/emacs-devel/2020-04/msg00265.html

* lisp/org/org-table.el (org-table-finish-edit-field):
* lisp/arc-mode.el (archive-rar-summarize):
Avoid wrapped subsumption in repeated sequences.
* lisp/erc/erc-dcc.el (erc-dcc-ctcp-query-send-regexp): Replace
inefficient repeated empty-matching expression with a plain greedy
form.
(erc-dcc-handle-ctcp-send): Adjust group numbers.
* lisp/net/puny.el (puny-encode-domain): Fix fast-path shortcut
pattern so that it actually works as intended.
* lisp/progmodes/gdb-mi.el (gdb-control-commands-regexp):
* lisp/vc/diff-mode.el (diff-imenu-generic-expression):
Remove superfluous backslashes.
* lisp/progmodes/scheme.el (scheme-imenu-generic-expression):
Correct confused definition-matching pattern which would match more
than intended.
* lisp/textmodes/sgml-mode.el (sgml-tag-name-re): Avoid inefficient
matching by using the fact that the first character cannot match the
last char of sgml-name-re.
lisp/arc-mode.el
lisp/erc/erc-dcc.el
lisp/net/puny.el
lisp/org/org-table.el
lisp/progmodes/gdb-mi.el
lisp/progmodes/scheme.el
lisp/textmodes/sgml-mode.el
lisp/vc/diff-mode.el