]> git.eshelyaron.com Git - emacs.git/commit
Use make-directory handlers uniformly
authorPaul Eggert <eggert@cs.ucla.edu>
Sat, 17 Dec 2022 20:15:30 +0000 (12:15 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Sat, 17 Dec 2022 22:24:16 +0000 (14:24 -0800)
commit8a9579ca29df951ace35125873949e905fd1af2b
treec0742b4d88da2c78a24dc4be844c9ec436d96520
parent627e7e0243d6df73b7cc93fb7a106a61c944b3bf
Use make-directory handlers uniformly

Formerly, the code supported both make-directory and
make-directory-internal handlers. This led to confusion and meant than
in a few cases (nnmaildir, ido) remote directories could not be used in
some cases.  Fix this by using only make-directory handlers.

Perhaps there used to be a reason for why there were both
make-directory and make-directory-internal handlers, but whatever that
reason was, it seems to have vanished even before now.

There is no longer any need for make-directory-internal handlers, as
the few remaining callers that use make-directory-internal do so only
when there are no handlers.  However, this change keeps the existing
make-directory-internal handlers for now, in case this code is ever
used in older Emacs versions that still call those handlers.

* lisp/gnus/nnmaildir.el (nnmaildir--mkdir):
* lisp/ido.el (ido-file-internal):
* lisp/net/tramp-smb.el (tramp-smb-handle-make-directory):
Use make-directory, not make-directory-internal.
* lisp/net/tramp-smb.el (tramp-smb-handle-make-directory-internal):
Now obsolete.
* src/fileio.c (Fmake_directory_internal): Do not look for or
use a make-directory-internal handler.
* test/lisp/files-tests.el:
(files-tests-file-name-non-special-make-directory-internal):
Remove, as this test incorrectly assumes that make-directory-internal
must support handlers.
doc/lispref/files.texi
etc/NEWS
lisp/gnus/nnmaildir.el
lisp/ido.el
lisp/net/tramp-smb.el
src/fileio.c
test/lisp/files-tests.el