]> git.eshelyaron.com Git - emacs.git/commit
Jsonrpc: don't bind inhibit-read-only to t so early
authorJoão Távora <joaotavora@gmail.com>
Fri, 7 Apr 2023 18:33:12 +0000 (19:33 +0100)
committerJoão Távora <joaotavora@gmail.com>
Fri, 7 Apr 2023 18:33:12 +0000 (19:33 +0100)
commit88847dee125aa333b79829744eb4b16e8fd59ee8
tree0d49651228b16de06539680439810ee655b980d6
parentcb8c87a423a4897d873180a9e9be99e2ec20488d
Jsonrpc: don't bind inhibit-read-only to t so early

Related to https://github.com/joaotavora/eglot/discussions/1202, where
because of this very wide binding to inhibit-read-only to t, Eglot was
managing to write into read-only buffers from the response handlers
that ran from within the stack of the jsonrpc.el process filter.

This is of course illegal and dangerous, but Eglot wasn't made aware
because of the binding.

* lisp/jsonrpc.el (jsonrpc--process-filter): Don't bind
inhibit-read-only so early.
lisp/jsonrpc.el