]> git.eshelyaron.com Git - emacs.git/commit
Eldoc: don't overdisplay if using eldoc-documentation-compose
authorJoão Távora <joaotavora@gmail.com>
Thu, 13 Apr 2023 10:46:12 +0000 (11:46 +0100)
committerJoão Távora <joaotavora@gmail.com>
Thu, 13 Apr 2023 16:42:37 +0000 (17:42 +0100)
commit83b5e9cd24ddcbb04dbd5db9a07248ff7fa301ab
treec0fc669c634cd2e205f553573679e78f21bbbe5c
parenta74403adda0d67b6f0430d1c038a7c96579f3450
Eldoc: don't overdisplay if using eldoc-documentation-compose

bug#62816

This is about a particular value for 'eldoc-documentation-strategy',
'eldoc-documentation-compose'.  Its helper
'eldoc--documentation-compose-1' was buggy.  It created the callback
for all the backends in 'eldoc-documentation-functions', but arranged
so that it could potentially be invoked immediately and trigger
display, half-defeating the purpose of the "patience" and causing
blinking in the echo area.

Now it creates all the callbacks beforehand and only then passes them
to the corresponding members of eldoc-documentation-functions.  This
sets up the correct state in eldoc--invoke-strategy.

* lisp/emacs-lisp/eldoc.el (eldoc--documentation-compose-1):
Delete.
(eldoc-documentation-compose)
(eldoc-documentation-compose-eagerly): Rework.
lisp/emacs-lisp/eldoc.el