]> git.eshelyaron.com Git - emacs.git/commit
Fix three Flymake bugs when checking C header files
authorJoão Távora <joaotavora@gmail.com>
Thu, 28 Sep 2017 11:06:56 +0000 (12:06 +0100)
committerJoão Távora <joaotavora@gmail.com>
Tue, 3 Oct 2017 13:18:55 +0000 (14:18 +0100)
commit8118f0f95f993f64f30ab1d48d9e988ab6f58019
tree18ec49524249a9673e129084a37e8f550b879f3a
parent9a629a73e0eb10589f5befaf0a1a3290d9ba6a47
Fix three Flymake bugs when checking C header files

The first of these problems is longstanding: if an error-less B.h is
included from error-ridden A.h, flymake's legacy parser will panic
(and disable itself) since it sees a non-zero exit for a clean file.
To fix this, recommend returning 'true' in the documentation for the
check-syntax target.

Another problem was introduced by the parser rewrite.  For error
patterns spanning more than one line, point may be left in the middle
of a line and thus render other patterns useless.  Those patterns were
written for the old line-by-line parser.  To make them useful again,
move to the beginning of line in those situations.

The third problem was also longstanding and happened on newer GCC's:
The "In file included from" prefix confused
flymake-proc-get-real-file-name.  Fix this.

Also updated flymake--diag-region to fallback to highlighting a full
line less often.

Add automatic tests to check this.

* lisp/progmodes/flymake-proc.el
(flymake-proc--diagnostics-for-pattern): Fix bug when patterns
accidentally spans more than one line.  Don't create
diagnostics without error messages.
(flymake-proc-real-file-name-considering-includes): New
helper.
(flymake-proc-allowed-file-name-masks): Use it.

* lisp/progmodes/flymake.el (flymake-diag-region): Make COL
argument explicitly optional.  Only fall back to full line in extreme
cases.

* test/lisp/progmodes/flymake-tests.el
(included-c-header-files): New test.
(different-diagnostic-types): Update.

* test/lisp/progmodes/flymake-resources/Makefile
(check-syntax): Always return success (0) error code.
(CC_OPTS): Add -Wextra

* test/lisp/progmodes/flymake-resources/errors-and-warnings.c
(main): Rewrite comments.

* test/lisp/progmodes/flymake-resources/errors-and-warnings.c:
Include some dummy header files.

* test/lisp/progmodes/flymake-resources/no-problems.h: New file.

* test/lisp/progmodes/flymake-resources/some-problems.h: New file.

* doc/misc/flymake.texi (Example---Configuring a tool called
via make): Recommend adding "|| true" to the check-syntax target.
doc/misc/flymake.texi
lisp/progmodes/flymake-proc.el
lisp/progmodes/flymake.el
test/lisp/progmodes/flymake-resources/Makefile
test/lisp/progmodes/flymake-resources/errors-and-warnings.c
test/lisp/progmodes/flymake-resources/no-problems.h [new file with mode: 0644]
test/lisp/progmodes/flymake-resources/some-problems.h [new file with mode: 0644]
test/lisp/progmodes/flymake-tests.el