]> git.eshelyaron.com Git - emacs.git/commit
Ignore erc-response objects in error-notice helper
authorF. Jason Park <jp@neverwas.me>
Fri, 18 Aug 2023 02:18:50 +0000 (19:18 -0700)
committerF. Jason Park <jp@neverwas.me>
Fri, 25 Aug 2023 21:47:07 +0000 (14:47 -0700)
commit75b3fb3cb42385612d446ee1907b87e64d988c2f
tree7b296927df2cfe84ebd731acdbbb7131ea53e710
parent2b311a47dd0cde82fb9d32c303f13700cae4f0b3
Ignore erc-response objects in error-notice helper

* lisp/erc/erc-button.el (erc-button--display-error-notice-with-keys):
Remove `parsed' `erc-response' positional parameter, and don't pass it
to `erc-display-message' because the latter adds text properties
derived from such an object.  These properties can confuse other code
operating on an inserted error-notice message into thinking it
originated from the server.
* lisp/erc/erc-common.el (erc--with-dependent-type-match): Make macro
more readable.
* lisp/erc/erc-networks.el (erc-networks--set-name,
erc-networks--ensure-announced, erc-networks-on-MOTD-end): Remove
`erc-response' objects from inserted error-notices.
* test/lisp/erc/erc-button-tests.el
(erc-button--display-error-notice-with-keys): Add assertions for
overloaded first parameter.
* test/lisp/erc/erc-tests.el (erc--with-dependent-type-match): Update
expected expansion.
lisp/erc/erc-button.el
lisp/erc/erc-common.el
lisp/erc/erc-networks.el
test/lisp/erc/erc-button-tests.el
test/lisp/erc/erc-tests.el