]> git.eshelyaron.com Git - emacs.git/commit
Remedy wrong-looking \(:?...\) regexp constructs
authorMattias Engdegård <mattiase@acm.org>
Wed, 16 Aug 2023 11:33:48 +0000 (13:33 +0200)
committerMattias Engdegård <mattiase@acm.org>
Wed, 16 Aug 2023 14:55:38 +0000 (16:55 +0200)
commit5b879501339b9426661fbf2a783287ad0949e3d6
tree1cbbcf936acd1cf959d1a67cdf1e61b8fc3899d9
parentd6c473a91da3ce8decae03ed32b91affbb040890
Remedy wrong-looking \(:?...\) regexp constructs

When we see \(:?...\) in a regexp it very much looks like a typo
for a \(?:...\) construct and often is, so do something about
all of these (one of which being another mistake).
Doing so silences an optional relint check.

* lisp/comint.el (comint-replace-by-expanded-history-before-point):
* lisp/term.el (term-replace-by-expanded-history-before-point):
Move :? out from capturing group where it does not need to be,
to avoid confusion.
* lisp/emacs-lisp/cl-indent.el (common-lisp-loop-part-indentation):
A capturing group isn't needed here; turn it into simple bracketing.
* lisp/progmodes/sql.el (sql--completion-table):
Change :? into ?: which was clearly meant here.
lisp/comint.el
lisp/emacs-lisp/cl-indent.el
lisp/progmodes/sql.el
lisp/term.el