]> git.eshelyaron.com Git - emacs.git/commit
Jsonrpc: prevent while-no-input messing with jsonrpc-request
authorJoão Távora <joaotavora@gmail.com>
Wed, 29 Nov 2023 00:47:09 +0000 (18:47 -0600)
committerJoão Távora <joaotavora@gmail.com>
Wed, 29 Nov 2023 00:47:09 +0000 (18:47 -0600)
commit5a0250f76676d8750f42bbca1af5c4553846949b
tree0b88768cfa7f7ee37ac4ccc629e0650483db25c0
parent02d88e36e911e76842369e565ca2dae9a7922f7b
Jsonrpc: prevent while-no-input messing with jsonrpc-request

'jsonrpc-request' already has its "interrupt on user input" mechanism
base on 'sit-for'.  If called from a situation that uses
while-no-input to do basically the same, that mechanism may become
confused, so it's important to prevent that interfence.

This was confirmed to be a problem when using the Corfu completion
front-end.

See also
https://github.com/joaotavora/eglot/discussions/1127#discussioncomment-7277567

Many thanks to JD Smith <jdtsmith@gmail.com> for helping me debug this
and pointing in the right direction.

* lisp/jsonrpc.el (Version): Bump to 1.0.18
(jsonrpc-request): Bind throw-on-input to nil
lisp/jsonrpc.el