]> git.eshelyaron.com Git - emacs.git/commit
Take stock of the wheel-up/down confusion
authorStefan Monnier <monnier@iro.umontreal.ca>
Wed, 24 Jan 2024 17:57:33 +0000 (12:57 -0500)
committerEshel Yaron <me@eshelyaron.com>
Wed, 24 Jan 2024 18:31:54 +0000 (19:31 +0100)
commit581d95788dcaa4a5b2c5e98a34b8bce6f713a6f8
tree5f866f501c88d6ce9a8bae1bb2c51973a8c0e352
parentca6ef5184434ce75a2da6e3106bdb27d16224c84
Take stock of the wheel-up/down confusion

While we're hopefully all aware of the usual confusion between
the scroll operation moving the document or moving the viewport, Emacs
has its very own instance of that confusion where the
`mouse-wheel-down-event` variable is the one that (used to) hold
the value `wheel-up` and vice versa.

Thanks for Po Lu's commit 957b4f826a4 which not only fixed my change
but brought that confusion to my attention.
This patch doesn't fix the problem, but tries to fix the other places
in the code where we did not take it into account.

* doc/lispref/commands.texi (Misc Events): Mention the
wheel-up/down confusion.

* lisp/progmodes/flymake.el (flymake--mode-line-counter-map):
* lisp/completion-preview.el (completion-preview--mouse-map):
Fix wheel-up/down confusion.

* lisp/mwheel.el (mouse-wheel-down-event, mouse-wheel-up-event):
Fix docstrings.

(cherry picked from commit 1f3371b46e8a6a51f88c56785175b48af2a0bed7)
doc/lispref/commands.texi
lisp/completion-preview.el
lisp/mwheel.el
lisp/progmodes/flymake.el