]> git.eshelyaron.com Git - emacs.git/commit
Don't immediately request completions in eglot-completion-at-point
authorJoão Távora <joaotavora@gmail.com>
Fri, 18 Oct 2019 15:43:50 +0000 (16:43 +0100)
committerJoão Távora <joaotavora@gmail.com>
Sat, 19 Oct 2019 20:40:42 +0000 (21:40 +0100)
commit5690e3a659b36717971e4f62108f82bda1b871d0
treea64c6b93f1f5755bc4e5ef0b5bc9c9e909149eb2
parent21c2bb18d898b5d70750688a51346b2b867e3265
Don't immediately request completions in eglot-completion-at-point

Yet another adjustment to this function.  According to the
documentation of completion-at-point-functions, we should strive to
make functions like eglot-completion-at-point "cheap to run".
Requesting completion from the server immediately after calling the
function goes against that.  The reason we were doing it is that it
might have helped compute more accurate "bounds" for the return value
(START and END) from possible TextEdit completion items.  But I've
decided it's not worth the effort, at least for now.

* eglot.el (eglot-completion-at-point): Request completions
asynchronously.
lisp/progmodes/eglot.el