]> git.eshelyaron.com Git - emacs.git/commit
Improve interactive prompting for face colors
authorHelmut Eller <eller.helmut@gmail.com>
Thu, 20 Jul 2023 14:27:34 +0000 (16:27 +0200)
committerEli Zaretskii <eliz@gnu.org>
Thu, 3 Aug 2023 07:45:41 +0000 (10:45 +0300)
commit5129ea4b0540a0df35be59cdaf2fe63260670e9f
tree7fb899a7c9a06e48f7925bf2ecf3806fe2533828
parentd727e8ee7c0b6f3457080c8a94ad54d6cffda911
Improve interactive prompting for face colors

When displaying the completion candidates, show how the face would
look with the new foreground/background.

* lisp/faces.el (faces--string-with-color): New helper,
factored out from 'defined-colors-with-face-attributes'.
(defined-colors-with-face-attributes): Use it.
(read-color): Add optional argument FACE and pass
it to 'faces--string-with-color.'
(read-face-attribute): Call 'read-color' with more appropriate
foreground and face arguments.

* doc/lispref/minibuf.texi (High-Level Completion): Describe
the intention behind the arguments FOREGROUND and FACE of
'read-color'.  (Bug#64725)
doc/lispref/minibuf.texi
lisp/faces.el