]> git.eshelyaron.com Git - emacs.git/commit
Fix spurious warnings from unwise condition order in inlined code
authorMattias Engdegård <mattiase@acm.org>
Thu, 4 Feb 2021 13:32:21 +0000 (14:32 +0100)
committerMattias Engdegård <mattiase@acm.org>
Sat, 6 Feb 2021 19:22:24 +0000 (20:22 +0100)
commit4dc3231c91c339e602f59dcfee372017b92e4318
treef600a3e24c5ddcc75d56150dfaabf3e45fc4df68
parent83983b6b7a115474572973b62eb5e42251713e63
Fix spurious warnings from unwise condition order in inlined code

These are both conditions having the form (and A B) where A is
side-effect-free and B may be known to be nil at compile time.
The compiler will then warn about A being useless and thrown away.
The fix is to test B first.

* lisp/gnus/gnus.el (gnus-method-to-server):
Test `(not no-enter-cache)` first.
(gnus-server-get-method): Test `group` first.
lisp/gnus/gnus.el