]> git.eshelyaron.com Git - emacs.git/commit
Eglot: fix bug introduced when "fixing" middle-of-symbol completions
authorJoão Távora <joaotavora@gmail.com>
Thu, 25 Jan 2024 12:10:40 +0000 (12:10 +0000)
committerEshel Yaron <me@eshelyaron.com>
Thu, 25 Jan 2024 18:06:15 +0000 (19:06 +0100)
commit4d64583568d57ca392191f9f0140ca1aaed84d13
tree4fb2f82661b0cacf0f281d3ccb2f65a034c81e58
parent87fd0082abc051ecb2a085842e5d56a05a7faf30
Eglot: fix bug introduced when "fixing" middle-of-symbol completions

Culprit:

    commit a6ef458e3831001b0acad57cf8fa75b77a4aff3f
    Author: João Távora <joaotavora@gmail.com>
    Date:   Tue Dec 26 00:31:29 2023 +0000

        Eglot: partial fix for middle-of-symbol completions

The decision to restore the buffer state to when the last LSP
completion set was invoked is rock-solid (because that the state
those completions' edits apply to).

However, when caching the LSP completions across multiple
eglot-completion-at-point calls, we must make sure to also restore the
values of the local values, such as 'bounds-string'.  This allows us
to do that restoration.

* lisp/progmodes/eglot.el (eglot-completion-at-point): Also
restore bounds-string from capf session cache.

Github-reference: https://github.com/joaotavora/eglot/issues/1349
(cherry picked from commit 5d88c98e7c101ebad68b562334020b8c082c2ca5)
lisp/progmodes/eglot.el