]> git.eshelyaron.com Git - emacs.git/commit
Deprecate erc-button-nickname-callback-function
authorF. Jason Park <jp@neverwas.me>
Mon, 7 Aug 2023 10:35:56 +0000 (03:35 -0700)
committerF. Jason Park <jp@neverwas.me>
Tue, 15 Aug 2023 23:47:20 +0000 (16:47 -0700)
commit4b17cc314771532fa1a6a617c3961f44bd2a5e7f
tree8e77601a36b3f2f34114902bfa7473d35e70c81d
parent35a670a2f6ca7aae97b7c5c11e57c732c5b31c36
Deprecate erc-button-nickname-callback-function

* lisp/erc/erc-button.el (erc-button-nickname-callback-function):
Deprecate this function-valued variable, first introduced in ERC 5.6
and Emacs 30, to dissuade consumers of the old `erc-button-alist'
nickname interface from meddling with the on-click callback of
buttonized nicks.  If necessary, third parties can instead add their
own propertizing logic in something like `erc-insert-modify-hook'.
Also change default callback to a wrapper that discards all but the
first arg.  This effectively declares that `erc-data' values for
nicknames may contain more than one element in the near future.
(erc-button--perform-nick-popup): New default nick-button callback
function wrapping `erc-nick-popup' in order to adapt it to the
`erc-button-nickname-callback-function' interface.  (Bug#60933)
lisp/erc/erc-button.el