]> git.eshelyaron.com Git - emacs.git/commit
avoid a sign-extension bug in crypto_hash_function
authorJim Meyering <meyering@redhat.com>
Sat, 28 May 2011 12:19:08 +0000 (14:19 +0200)
committerJim Meyering <meyering@redhat.com>
Sat, 28 May 2011 12:19:08 +0000 (14:19 +0200)
commit3eaff8342b4e193d142684f4ab03f391e3466c86
treed0e227b9c5e0985cd7959e9ac35d571f3abbb41c
parentd451b0879113e2dca94a5ffaf1e4bb9b31a260b6
avoid a sign-extension bug in crypto_hash_function

* fns.c (to_uchar): Define.
(crypto_hash_function): Use it to convert some newly-signed
variables to unsigned, to avoid sign-extension bugs.  For example,
without this change, (md5 "truc") would evaluate to
45723a2aff78ff4fff7fff1114760e62 rather than the expected
45723a2af3788c4ff17f8d1114760e62.  Reported by Antoine Levitt in
http://thread.gmane.org/gmane.emacs.devel/139824
src/ChangeLog
src/fns.c