]> git.eshelyaron.com Git - emacs.git/commit
Don't send erc-sasl-user as USER command argument
authorF. Jason Park <jp@neverwas.me>
Tue, 13 Dec 2022 07:58:03 +0000 (23:58 -0800)
committerF. Jason Park <jp@neverwas.me>
Wed, 14 Dec 2022 14:40:55 +0000 (06:40 -0800)
commit102a3e3b445d96e5a74a3ec32b2a2b701b80819e
treeaec20825d617f64062cc9080d9d6c85df2367f0c
parentf0c908887815a9cc668a5a03cbc1b7d6eaf8c91d
Don't send erc-sasl-user as USER command argument

* lisp/erc/erc-sasl.el (erc-sasl--send-cap-ls): Add internal switch
for sending an opening "CAP LS".  The rationale for not enabling this
by default is twofold: one, it more strongly implies that ERC supports
IRCv3 client capability negotiation, which is somewhat disingenuous;
and, two, We'd still be "faking it" by firing and forgetting, and more
balls in the air makes things less predictable.
(erc--register-connection): Possibly send a "CAP LS" before anything
depending on the value of `erc-sasl--send-cap-ls'.  Also, don't
attempt to send `erc-session-username' when it holds an SASL username
because the latter may contain protocol-defying characters.
* test/lisp/erc/resources/base/local-modules/fourth.eld: change user
parameter of "USER" command to reflect nick when `erc-sasl-user' is
set to `:user'.  (Bug#59976.)
lisp/erc/erc-sasl.el
test/lisp/erc/resources/base/local-modules/fourth.eld