]> git.eshelyaron.com Git - emacs.git/commit
Give up on -Wsuggest-attribute=const
authorPaul Eggert <eggert@cs.ucla.edu>
Fri, 16 Jan 2015 04:37:05 +0000 (20:37 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Fri, 16 Jan 2015 04:37:44 +0000 (20:37 -0800)
commit0adc75af1833cd46aab339ce7f1ca5d6919c70af
treefb4bc7c0172c31f8313bbde3dabe4ef9bf5fe07e
parent255d2a5a53083d676977023e9772d97095c6db46
Give up on -Wsuggest-attribute=const

The attribute doesn't help performance significantly, and the
warning seems to be more trouble than it's worth.  See the thread at:
http://lists.gnu.org/archive/html/emacs-devel/2015-01/msg00361.html
* configure.ac (WERROR_CFLAGS): Don't use -Wsuggest-attribute=const.
* lib-src/make-docfile.c (write_globals):
Remove special hack for Fnext_read_file_uses_dialog_p.
* src/decompress.c (Fzlib_available_p):
* src/gnutls.c (Fgnutls_available_p):
* src/gtkutil.h (xg_uses_old_file_dialog):
* src/xdisp.c (Ftool_bar_height):
* src/xmenu.c (popup_activated):
No longer const, since it's not const on at lest some
configurations, and we shouldn't lie to the compiler.
ChangeLog
configure.ac
lib-src/ChangeLog
lib-src/make-docfile.c
src/ChangeLog
src/decompress.c
src/gnutls.c
src/gtkutil.h
src/xdisp.c
src/xmenu.c