]> git.eshelyaron.com Git - emacs.git/commit
Fix bug in how ERT invokes its debugger.
authorPhilipp Stephani <phst@google.com>
Mon, 7 Dec 2020 20:41:40 +0000 (21:41 +0100)
committerPhilipp Stephani <phst@google.com>
Mon, 7 Dec 2020 20:41:40 +0000 (21:41 +0100)
commit0155bd0fdb166c97a2ce76cc5bc64fd195a676d3
tree0746cc2410658fc03931dfeb942cd8b477965dd4
parent0c330bed24ef045732a1bfe61d20ed8328dd0b28
Fix bug in how ERT invokes its debugger.

The debugger needs to receive a list of the error symbol and data;
cf. the documentation of the `debugger' variable.  This bug manifested
itself in ERT forms such as (should (integerp (ert-fail "Boo"))),
which resulted in an incorrect condition object.  Note that forms such
as (should (ert-fail "Boo")) weren't affected because they wouldn't
use the `ert--should-signal-hook'.

* test/emacs-lisp/ert.el (ert--should-signal-hook): Call debugger with
the right arguments.

* test/lisp/emacs-lisp/ert-tests.el (ert-test-fail-inside-should): Add
unit test.
lisp/emacs-lisp/ert.el
test/lisp/emacs-lisp/ert-tests.el