]> git.eshelyaron.com Git - emacs.git/commit
Fix for 'windmove-do-window-select' if other-window is 'no-select
authorgit@toki.la <git@toki.la>
Fri, 11 Jul 2025 19:34:35 +0000 (12:34 -0700)
committerEshel Yaron <me@eshelyaron.com>
Fri, 25 Jul 2025 08:07:56 +0000 (10:07 +0200)
commit0035565a390e0f0ad30fa6476ef67e2477cf533d
tree173e005379e861e9a15a749fbc52deba8da89ca6
parentbb6dce33c14df5090030bc91f8d76c3486ce3d90
Fix for 'windmove-do-window-select' if other-window is 'no-select

If the variable 'windmove-create-window' is set to a function
that returns 'no-select', 'windmove-do-window-select' is intended
to ignore the final window selection.  However, because
'other-window' is passed to 'window-minibuffer-p' before checking
if 'other-window' is 'no-select', 'window-minibuffer-p' will
instead throw a type error, and the '(eq other-window 'no-select)'
case will never be reached.  This patch moves this case up a line
to avoid this.
* lisp/windmove.el (windmove-do-window-select): Check for
'no-select' value earlier.  (Bug#78997)

Copyright-paperwork-exempt: yes
(cherry picked from commit 256dfdf11f40d94a86490d1b68bb86935e2d3f03)
lisp/windmove.el